New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customer/address delete resulting in error on cart page #11416

Merged
merged 3 commits into from Nov 16, 2018

Conversation

Projects
None yet
6 participants
@tomlev
Member

tomlev commented Nov 16, 2018

Questions Answers
Branch? 1.7.5.x
Description? Fix php error on BO>carts when deleting a customer or an address used in abandonned cart
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #9782
How to test? 1/ On FO create a customer account, add a product in cart, go to checkout and store an address on the cart. On BO go to customers and delete the customer with second delete option. go to orders>cart, no error should be displayed. 2/ Same FO process but on BO delete the address. Carts page should not display error

This change is Reviewable

@@ -221,6 +221,15 @@ public function delete()
}
if (!$this->isUsed()) {
// keep pending carts, but unlink it from current address
$sql = 'UPDATE ' . _DB_PREFIX_ . 'cart

This comment has been minimized.

@PierreRambaud

PierreRambaud Nov 16, 2018

Contributor

Can you separate this in a function like clearCartAddress or something like?

tomlev added some commits Nov 16, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Nov 16, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 16, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 584614a into PrestaShop:1.7.5.x Nov 16, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 16, 2018

Thank you @tomlev

@jolelievre jolelievre changed the title from fix customer/address delete resulting in error on cart page to Fix customer/address delete resulting in error on cart page Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment