New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Customer list actions #11439

Merged
merged 33 commits into from Jan 16, 2019

Conversation

@sarjon
Copy link
Member

sarjon commented Nov 20, 2018

Questions Answers
Branch? develop
Description? Migrates all bulk actions and Enable, Newsletter, Partner offers and Delete row actions.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10559
How to test? Migrated actions should be working now. Check admin/sell/customers to access this page. NOTE: build assets before testing. Travis report is red because of conflicts but this PR can be validated 👍 .

customers_grid


This change is Reviewable

@matks matks referenced this pull request Dec 12, 2018

Open

Migrate "Customers > Customers" page #10559

5 of 7 tasks complete
@sarjon

This comment has been minimized.

Copy link
Member Author

sarjon commented Dec 13, 2018

@matks addressed comments. 👍

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 13, 2018

@sarjon PR approved 😄 however Travis fails because of assets :(
Let's get QA approval before rebase + merge

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Dec 14, 2018

@sarjon

  1. The export doesn't work

capture d ecran_769

  1. I have 12 customers, I choose to display 10, but still 12 are displayed

capture d ecran_766

  1. In all shop context & default group context, the message "You should select a shop to create a customer" is not displayed

capture d ecran_767

capture d ecran_768

Don't know if 2) & 3) can be solved in this PR or in another one

@sarjon

This comment has been minimized.

Copy link
Member Author

sarjon commented Dec 14, 2018

@marionf 1) and 2) fixed. 3) is already part of another PR. :)

Note that export does not take into account filters as it's being implemented in #10830

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Dec 14, 2018

It's good, thank you @sarjon 👍

@sarjon sarjon force-pushed the sarjon:migrate/customers-list-actions branch from e9fe950 to 88f5ffb Jan 14, 2019

@sarjon

This comment has been minimized.

Copy link
Member Author

sarjon commented Jan 14, 2019

@matks rebased. 👍

@sarjon

This comment has been minimized.

Copy link
Member Author

sarjon commented Jan 14, 2019

any ideas why tests fail?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 14, 2019

There was an issue with develop that has been solved (see #12150)
I relaunch tests, let's see if it was the reason of the failure

@sarjon

This comment has been minimized.

Copy link
Member Author

sarjon commented Jan 15, 2019

@matks all good now, merge? ^^

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 16, 2019

Yes ! Thanks @sarjon

@matks

matks approved these changes Jan 16, 2019

@matks matks merged commit e53dce6 into PrestaShop:develop Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment