New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape everything! #11447

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Contributor

PierreRambaud commented Nov 20, 2018

Questions Answers
Branch? 1.7.5.x
Description? Escape some strings. Thanks Antonin Steinhauser
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? I will show you :)

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Nov 20, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 20, 2018

I will show you :)

Show me now 👍

@marionf marionf assigned marionf and unassigned marionf Nov 21, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 21, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Nov 21, 2018

Thanks @PierreRambaud and @marionf for the QA review 👍

@mickaelandrieu mickaelandrieu merged commit 1dc5da9 into PrestaShop:1.7.5.x Nov 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:let-s-escape-strings branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment