New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless trad files in install for persian #11448

Merged
merged 2 commits into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Nov 20, 2018

Questions Answers
Branch? 1.7.5.x
Description? When installing the persian language, the process stops during module installation Because persian language still contains install data files that override the english ones thus some data are missing and cause a bug later in the process. Those files have been removed in this PR.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11354
How to test? Clone the branch and go to the install-dev address, try to install PrestaShop in persian and go to the end of the process.

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.0 milestone Nov 20, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 20, 2018

Okay, we remove all the translations. But are they still provided by a language pack during the installation?

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 20, 2018

@Quetzacoalt91 yes of course, it is the same process from french or any other language
Although I still don't know when/where it translates the database values
I can see that the language packages are downloaded and installed here:

$languages = $this->installLanguages($iso_codes_to_install);

But it seems to be about emails and symfony translations, I don't know it this part also translates the database, but anyway it works

@marionf marionf self-assigned this Nov 21, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 21, 2018

@marionf marionf removed their assignment Nov 21, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit e6b3726 into PrestaShop:1.7.5.x Nov 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 21, 2018

Thank you @jolelievre

@jolelievre jolelievre deleted the jolelievre:clean-persian-install branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment