New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary spaces on header of the checkout page #11455

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
7 participants
@dineshbadrukhiya
Copy link
Contributor

dineshbadrukhiya commented Nov 21, 2018

Questions Answers
Branch? develop
Description? We need to improve design of checkout page header in classic theme by removing unnecessary spaces
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11454
How to test? Go to 'Checkout page on FO'

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Nov 21, 2018

Hello @dineshbadrukhiya!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Nov 21, 2018

Hello @dineshbadrukhiya,

would you mind to build your assets again? You may needs to rebase your pull request first.

Thanks for your help!

@dineshbadrukhiya

This comment has been minimized.

Copy link
Contributor

dineshbadrukhiya commented Nov 21, 2018

@mickaelandrieu what’s the reason to build it again? I’m just asking for my knowledge😀. Can you please tell me the necessary steps as I have not idea how to do it as you have said may needs to rebase?

@TristanLDD TristanLDD added UX ✔️ and removed waiting for UX labels Nov 23, 2018

@Quetzacoalt91 Quetzacoalt91 force-pushed the dineshbadrukhiya:Fix-#11454 branch from 700f055 to 06e15ca Nov 23, 2018

@marionf marionf self-assigned this Nov 23, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 26, 2018

@marionf marionf removed their assignment Nov 26, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 26, 2018

@PierreRambaud PierreRambaud merged commit cf212be into PrestaShop:develop Nov 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 26, 2018

Thanks @dineshbadrukhiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment