New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin translation redirect #11463

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
5 participants
@tomlev
Member

tomlev commented Nov 21, 2018

Questions Answers
Branch? 1.7.5.x
Description? fix language lost when redirecting to module translation edit (module using old translation system)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #11253
How to test? install the module in the ticket. install another language. in BO go to international > translations. choose "module translation', your module and the new language. click "edit". change some translation, save. you should see a file [lang].php in the module directory>translations, containing key hash and the modified translation

This change is Reviewable

@marionf marionf self-assigned this Nov 21, 2018

@marionf

This comment has been minimized.

Contributor

marionf commented Nov 21, 2018

@tomlev
It's ok for the test module provided in the issue.
But if I try this PR with another module (ps_mainmenu for exemple), I have an empty file [lang].php and translations are saved in DB, this is normal I think ?

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 22, 2018

@marionf marionf removed their assignment Nov 22, 2018

@PierreRambaud PierreRambaud merged commit 73df7cb into PrestaShop:1.7.5.x Nov 22, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Nov 22, 2018

Thanks @tomlev and @marionf for the QA ;)

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Nov 22, 2018

@jolelievre jolelievre changed the title from fix admin translation redirect to Fix admin translation redirect Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment