New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup /tests directory #11464

Merged
merged 4 commits into from Nov 26, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Copy link
Member

sarjon commented Nov 21, 2018

Questions Answers
Branch? develop
Description? It moves tests (except for Selenium and E2E) to tests-legacy directory.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? #10733
How to test? Travis should be green.

This change is Reviewable

@sarjon

This comment has been minimized.

Copy link
Member

sarjon commented Nov 21, 2018

@matks here's PR. :)

@mickaelandrieu @PierreRambaud your reviews would be nice as well.

Things left to do:

  • Maybe update legacy tests namespace to Tests => LegacyTests?
  • should check_e2e.sh be left under original tests/ dir?
  • Move valid Unit tests back to tests dir or do it in separate PR?
@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Nov 21, 2018

Hi there, can I remove the 'Waiting for Wording' label?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 21, 2018

@LouiseBonnard Yes you can.

@sarjon

This comment has been minimized.

Copy link
Member

sarjon commented Nov 22, 2018

seems that unit tests are okay, but e2e are not. :/ any ideas?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 26, 2018

@sarjon I think check_e2e should stay with E2E tests. It's not perfect but we can deal with 1 file "not in the right place" 😄

E2E tests error seem to happen at The blocktopmenu 1) should be shown on the home page so maybe it's because some test fixtures modules was moved and is now not installed anymore on e2e folder. I'm gonna have a look.

@sarjon sarjon force-pushed the sarjon:tests-cleanup branch from febabbf to 068f3c2 Nov 26, 2018

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 26, 2018

Thanks @sarjon this is a great step for Prestashop automatic testing 😄

@matks matks merged commit 501a95d into PrestaShop:develop Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sarjon sarjon deleted the sarjon:tests-cleanup branch Nov 26, 2018

@matks matks added this to the 1.7.6.0 milestone Nov 26, 2018

@matks matks referenced this pull request Nov 26, 2018

Open

Reorganize tests folder #10733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment