New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout #11486

Merged
merged 4 commits into from Nov 26, 2018

Conversation

Projects
None yet
5 participants
@eternoendless
Copy link
Member

eternoendless commented Nov 23, 2018

Questions Answers
Branch? 1.7.5.x
Description? Fix header appearing on top of modals
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11042
How to test? See ticket

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Nov 23, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 23, 2018

Regarding this comment, popovers do not belong to the UI kit and should be removed.

For information, I don't think that this behavior is really a bug, but Bootstrap's intended behavior coupled with an edge case. As you can see in this screencap from Bootstrap's source code, popovers have a higher z-index than modals, which means they are supposed to be displayed above them:
screenshot 2018-11-23 at 17 17 08

I can only guess about the reasoning behind it. My take is that:

  • If they had a lower z-index then they wouldn't be usable inside a modal.
  • Popovers aren't really meant to be "sticky" (that is, still be shown even after you click on something else), so this problem shouldn't exist really.

Why are they sticky? Because dismissable popovers don't work for the element we use them on.

@marionf marionf self-assigned this Nov 26, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 26, 2018

@marionf marionf removed their assignment Nov 26, 2018

@PierreRambaud PierreRambaud merged commit 399153b into PrestaShop:1.7.5.x Nov 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment