New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill php73 #11510

Merged
merged 3 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Nov 26, 2018

Questions Answers
Branch? develop
Description? Allow the use of the method is_countable on the project
Type? improvement
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? The method is properly defined even without PHP 7.3

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 26, 2018

Not sure QA is needed. @matks One more approve and merge?

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 26, 2018

@Quetzacoalt91 @PierreRambaud What happens if someone installs PrestaShop on a php 7.3 server ? (if we merge this PR)

@PierreRambaud

This comment has been minimized.

@matks

matks approved these changes Nov 26, 2018

@matks matks merged commit 5bdca82 into PrestaShop:develop Nov 26, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 26, 2018

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:polyfill-php73 branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment