New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests-legacy tests to namespace LegacyTests #11529

Merged
merged 2 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@matks
Copy link
Contributor

matks commented Nov 27, 2018

Questions Answers
Branch? develop
Description? Migrate tests-legacy tests to namespace LegacyTests
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? #10733
How to test? Travis tests should be green

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 28, 2018

No need QA, wiating for someone else to approve and merge :)

@@ -24,7 +24,7 @@
* International Registered Trademark & Property of PrestaShop SA
*/
namespace Tests\Unit\Core\Webservice;
namespace LegacyLegacyTests\Unit\Core\Webservice;

This comment has been minimized.

@jolelievre

jolelievre Nov 28, 2018

Contributor

LegacyTests too much legacy!

@jolelievre
Copy link
Contributor

jolelievre left a comment

Careful, you integrated rtl css files in the PR which have no link with this PR
And shouldn't be commit anyway since they are generated on install

I'm blind today --'

@matks matks force-pushed the matks:refactor-legacy-tests-namespace branch from efe539e to 0ea626e Nov 28, 2018

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Nov 28, 2018

My bad 😢
Commit 0ea626e fixed by push-force

@matks matks added this to the 1.7.6.0 milestone Nov 28, 2018

@matks matks merged commit 6e550c7 into PrestaShop:develop Nov 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matks matks deleted the matks:refactor-legacy-tests-namespace branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment