Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrate legacy import logic to adapters and hide Import page 2 #11561
P.S. Noticed that when you have multistore enabled and "All shops" selected, you cannot import products - stock update fails. You must select a single shop to import it.
My internal checklist for this PR:
Futher issues to be solved in additional PRs:
This is one of the two PR discussed here: #11160 (comment)
At the moment in this PR only product import logic is migrated, but I'm working on migrating other import types as well.
referenced this pull request
Nov 29, 2018
Hi @rokaszygmantas ! Code review is done. Sorry it was late, computer crashed on Friday
While reviewing I understood a lot of things:
In order to allow a future rework, I would like that we setup a dedicated test folder in
So this would be "black box" tests: setup system, set an initial state, apply change (here, a CSV import being processed), check final test, reset initial state, repeat with next sample.
What do you think about it ?
Hi @mickaelandrieu, thanks for suggestion!
I would really like to split it, because the PR is already enormous big. But should I wait for each PR to be merged before opening another, or what could be the strategy?