New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build all the assets using a single command #11566

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@eternoendless
Copy link
Member

eternoendless commented Nov 29, 2018

Questions Answers
Branch? develop
Description? Added a script that simplifies rebuilding all the assets. Just run ./tools/assets/build.sh from the project root.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Build all your assets :)

This change is Reviewable

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 left a comment

                                                                                                                                                      
                          ++++++++:`o+++s+++oo++++oo+++: /+++++++/`      `o++++++`o+++o -o+++/   `o+++++++so++os+++oo++++++:                          
                          h.  `. `+oh   d-  /N:  -N+  -s h.  .`  :s      -h    `h.y   d`/+  .y   .y``   ``m:  /d   dd`  ``/o                          
                          h.  +h  `hh   d-  /N:  -N+  .s h.  sy   d`     ++  .  s+y   d`/+  .y    /oy   h+y:  :d   dd`  ss+.                          
                          h.  .- .ssh   d-  /N:  -N+  .s h.  sy   d`     s- `s  :yy   d`/+  .y     -h   h`+:  `.   dd`  -:o/                          
                          h.  :+  -hh   d-  /N:  -N+  .s h.  sy   d`    `y` .d` `dh   d`/+  .y     -h   h`+:  .:   dd`  :/o:                          
                          h.  +h   dd   d-  +N:  -N+  .h:d.  sy   d`    -s   .   hd   h:s+  .h:-   -h   h`+:  :d   dd`  s+/-                          
                          h.  .-  `hh.  /` `sd:  -N+   .-N.  -.  .h     ++  .h.  +d   ..y+   .-h`  -h   h`+:  /d   dd`  `.-y                          
                          o+//////o:.++/::/o:/+//+yo/////h//////+o-     /+//+y+//+y/////so/////o   .s///s`:+//oy///ss//////o                          
                           ```````    ``.``   ```` ``````````````        ```` `````````````````     `````  ````````````````       ```                 
                            ```                                                                        .yso-                  ``....`                 
                            `...``               .-------.---..---..---..---..---` .-----`  `-----.     ydd:              ``......``                  
                             `....``            .s-------d/--+h---hh:--sh:--yh--+oo+-.--:o//o:.-.-+o    ``y.           ``........`                    
                             `.......`          .s::   /:d-  /h   dd`  sm`  /d  :do  .y  `hd`  y.  y.     d        ``..........`                      
                              `........``        `:y  `h-y-  -o   dd`  sm`  `o  :N/  -N:::hd`  +osss-..` .y     ``............`                       
                              `...........`       -y  `h`y-   `   dd`  sm`   `  :N/  -s///h+s:` `-+s-.`  /o  ``.............``                        
                               `............``    -y  `h`y-  :s   dd`  sm` .-   :N/  -h`  yy+s+o.  ++`   o:................`                          
                                `..............`` -y  `h`y-  /h   dd`  sm` -h`  :m+  -m`  ym`  h/  /o ``.y-...............`                           
                                `.................:y``.h`s:``/h```hd.``sm.`:m+``/ss:``--.`yso.`.``-s:...-y-.............`                             
                                 `................-+///:`:+++++++//:://+++++///::.`://+o+++-:++++++:....:s.............`                              
                                  .....................``...........``........    ``....................+o............`                               
.                                 `................................---------..```.......................s/..........`                                 
.                                  `..........................-:/++++//::/+++:...........-:/++/-........y:.........`                                  
             ``                     ........................:yy+-```````````.+s:.......-oy/. `.+o-.....-y-........`                                   
             `...```                `.......................-:/oo+.````````..-+h+++++++dm`   `. /s.....-s........`                                    
               `......``             `...........................:+o+-:++///::-:`      md     ` -y...../o.......`                                     
                 `........``          `...........................-ss+-`               oMy.    :hs-....o/......`                                      
                   ``.........`        `.....................:o+/od.         `-:+soo++/:.ohyso+: .y:...y-.....`                                       
                     ``..........``     ...................-s/`   :s-     -oo+/:/y/o+oyMy`        `s/.-h.....`                                        
      -h+/-            `..............```..................++ -    -s .:so/.++dMMMMMMMMMMh`        `y::y....`                                         
`    `ys..os-            `.................................:y.    `soh:`+yyNMMMMMMMMMMMMMMy         -s+o...`                                      ``` 
s+//+o/````./o+           `.................................:o+//+osd:.hMMMMMMMMMMMMMMMMMMM/        `hy/...                                 ```....`` 
/y-:..```````./y:          `..................................-+o` sooNMMMMMMMMMMMMMMMMMMMMd         ym-..`     `````````             ```........``   
ds:````````````.+s-          ``................................-y. `-yNMMMMMMMMMMMMMMMMMMMMN.       `md...```.........``          ``..........``      
d.```````````````.s:    ``````..................................ys    -odMMMMMMMMMMMMMMMMMMM/       smh.............``        ``............`         
/s.```````````````.y-    ``.....................................:y+     `/dMMMMMMMMMMMMMMMMM+       hyd-...........`     ```.............``           
 -y.```````````````-s.     ``....................................-h/      `oMMMMMMMMMMMMMMM+:      -dsho.........`   ``...............``              
  -s:```````````````+/       ``...................................-y+`     `mMMMMMMMMMMMMMh::     `yyssd:.......```................``                 
   .oo.````````````.s-         ``.................................-+ds      dNMMMMMMMMMMm/+o:    `yysssyy.......................``                    
     :s:-.....-::/+y/             `............................-/++/:y+     s/shyNmmmmh:-+s`    `shsssssd/....................`                       
      .-::::::/oddhhds.           ``.......................-:/o+/-...-yo    `.:/odhyys++o/`    `ohssssssyy.................``                         
                -ydhhhh+``````..........................-:+o+:-.......-ss.       `````        `ohssssssssd:..............``                           
                 `+hhhhdy/...........................-:+o/:-...........-/hs-``           ``-+syysssssssssyy.............`                             
                 ``-ohhhhds:......................-/++/-................./myys+:::-:::::+syyysssssssssssssd:..........`                               
       ```````      `:ydhhhh+-................-:/o+/-.....................shssyyyyyyyyyyysssssssssssssssssys.........`````````````````````            
       ...........`````/hhhhdy/............-:+o+:-........................-yhssssssssssssssssssssssssssssssd:...................................```   
       ``...............-sdhhhds-.......-:+o+:.............................-yysssssssssssssssssssssssssssssyy........................................`
         `................:ydhhhh+-..-/oo/-.................................:hysssssssssssssssssssssssssssssd:........................................
          `................-+hhhhdyoo+/-.....................................+hssssssssssssssssssssssssssssshs.................................````   
           `.................-sddddds-........................................hyssssssssssssssssssssssssssssyd-..........................```          
            `.................-+hdhhhh/......................................./dsssssssssssssssssssssssssssssh/....................````               
             `..................-+dhhhdy:.....................................:dsssssssssssssssssssssssssssssho...............```                     
              `...................-sdhhhdo-...................................:dsssssssssssssssssssssssssssssho...........``                          
                `...................:hhhhdh:..................................ohsssssssssssssssssssssssssssssho.......``                              
                 `....................+dhhhds-................................yysssssssssssssssssssssssssssssho.......`                               ```

@PierreRambaud PierreRambaud merged commit 8a6aa4e into PrestaShop:develop Nov 29, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 29, 2018

Let's merge this, we will improve this script later :)
Thanks @eternoendless

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Nov 29, 2018

@eternoendless eternoendless deleted the eternoendless:build-all-the-assets branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment