New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jquery shortcut function 'load' deprecate #11608

Merged
merged 2 commits into from Dec 22, 2018

Conversation

Projects
None yet
6 participants
@Fabuloops
Copy link
Contributor

Fabuloops commented Dec 4, 2018

Questions Answers
Branch? develop
Description? The "load" shortcut function in jQuery > 3.X should not be used anymore https://jquery.com/upgrade-guide/3.0/#breaking-change-load-unload-and-error-removed
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Use JQuery > 3.X => compile your assets with webpack and look at your console. It's will tel you something like 'url.indexOf is not a function'

This change is Reviewable

@prestonBot prestonBot added the Bug label Dec 4, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 4, 2018

Hi @Fabuloops,

Can you please commit the generated assets for the QA review?

Note to the QA team: the address step of the checkout works as before.

@Fabuloops

This comment has been minimized.

Copy link
Contributor

Fabuloops commented Dec 4, 2018

Hi @Quetzacoalt91,

I don't understand what you look for by "generated assets"

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 4, 2018

I meant "compiling your assets with webpack" :)

@Fabuloops

This comment has been minimized.

Copy link
Contributor

Fabuloops commented Dec 4, 2018

The core.js ?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 4, 2018

This one exactly. :)

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 4, 2018

Builds assests in FO Core:

cd themes/
npm install
npm run build
@Fabuloops

This comment has been minimized.

Copy link
Contributor

Fabuloops commented Dec 4, 2018

Hi @MathiasReker,

I have run "npm run watch" do you need the production compilation ?
This branch is under jQuery 2.2.4 where function load is not deprecated

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 4, 2018

I'd like to have the production version indeed, as these files are published in the release package. Thanks.

However, no need to commit the package-lock.json. :)

@prestonBot prestonBot added the develop label Dec 6, 2018

@Quetzacoalt91 Quetzacoalt91 force-pushed the Fabuloops:js-core-jquery-load-shortcut-deprecated branch from 947e271 to 33056af Dec 6, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 6, 2018

PR rebased.

@Quetzacoalt91 Quetzacoalt91 force-pushed the Fabuloops:js-core-jquery-load-shortcut-deprecated branch from 33056af to d60a7a0 Dec 21, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 21, 2018

Rebased, ready for merge

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 22, 2018

@PierreRambaud PierreRambaud merged commit 54dd686 into PrestaShop:develop Dec 22, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 22, 2018

Thanks @Fabuloops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment