New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional PHP Improvements #11643

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
5 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 6, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Everything should work as before.

This change is Reviewable

Show resolved Hide resolved classes/Customer.php Outdated

MathiasReker added some commits Dec 7, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 7, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 7, 2018

ping @PierreRambaud, except if I'm wrong this can't be validated by QA team: LGTM?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 7, 2018

@mickaelandrieu Agreed with you!

@mickaelandrieu mickaelandrieu merged commit ed0bb58 into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

So be it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment