New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed the override of _PS_DEBUG_PROFILING_ #11653

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
5 participants
@SebBareyre
Copy link
Contributor

SebBareyre commented Dec 7, 2018

Questions Answers
Branch? develop
Description? Allow to override PS_DEBUG_PROFILING constant in defines_custom.inc.php
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Just add define( '_PS_DEBUG_PROFILING_', true ); in defines_custom.inc.php

This change is Reviewable

[CO] Allow to override _PS_DEBUG_PROFILING_
Allow to override _PS_DEBUG_PROFILING_ constant in defines_custom.inc.php
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 7, 2018

Hi @SebBareyre,

in which cases do you want to use the legacy profiler? I'm wondering if we can improve the one available in the migrated pages.

Mickaël

@mickaelandrieu mickaelandrieu changed the title [CO] Allow to override _PS_DEBUG_PROFILING_ Allowed the override of _PS_DEBUG_PROFILING_ Dec 7, 2018

@SebBareyre

This comment has been minimized.

Copy link
Contributor

SebBareyre commented Dec 7, 2018

Hi @mickaelandrieu

I need to use it on front office.
By the way, there is a problem on the profiling tool : #9659

Seb

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Dec 10, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Dec 10, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 11, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 1ce076c into PrestaShop:develop Dec 11, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 11, 2018

Thank you @SebBareyre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment