New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error suppression #11669

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 8, 2018

Questions Answers
Branch? develop
Description? Improve error suppression
Type? improvement
Category? CO
BC breaks? /
Deprecations? /
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 9, 2018

Not exactly sure about this. Let me know if I should close this PR.

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

Not exactly sure about this. Let me know if I should close this PR.

Hmm, why not? This is the recommended way to do it in order to use the deprecation helper of Symfony.

Good for me!

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

@mickaelandrieu mickaelandrieu merged commit 330ce9c into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

@mickaelandrieu because the changes are done on code that is deprecated from 1.7.6 and the PR will be merged in 1.7.6 :) But you are right, lets just merge the changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment