New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constant instead of function #11671

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 8, 2018

Questions Answers
Branch? develop
Description? Use constant instead of function.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 9, 2018

Merged this PR here -> #11664
I let this stay open, but rather review this PR: #11664

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

I let this stay open, but rather review this PR: #11664

Believe me, it's far better for everyone to review and merge little (but still highly valuable) contributions than very big ones 👼

Thanks!

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

@mickaelandrieu mickaelandrieu merged commit d9cc16c into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment