New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non printable character #11672

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 8, 2018

Questions Answers
Branch? develop
Description? Remove Zero-width space (ZWSP), Non-breaking space (NBSP) and other invisible unicode symbols.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

Hello @MathiasReker,

how did you detect/remove them? I'd like to add a script to check and clean the files if any error: WDYT?

Mickaël

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 10, 2018

@mickaelandrieu you could do something like this: #11685 :)

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

Thanks @MathiasReker!

LGTM

@mickaelandrieu mickaelandrieu merged commit ad11d44 into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment