New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PHP unit construct #11674

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 8, 2018

Questions Answers
Branch? develop
Description? PHPUnit assertion method calls like ->assertSame(true, $foo) should be written with dedicated method like ->assertTrue($foo).
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker MathiasReker changed the title PHP unit construct Simplify PHP unit construct Dec 9, 2018

@mickaelandrieu
Copy link
Contributor

mickaelandrieu left a comment

Good job, thank you!

@mickaelandrieu mickaelandrieu merged commit cc9eb2e into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment