New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PHP unit expectations #11675

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 8, 2018

Questions Answers
Branch? develop
Description? ->setExpectedException* methods should be replaced by ->expectException* methods.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Everything should work the same.

This change is Reviewable

Improvements
->setExpectedException* methods MUST be replaced by ->expectException* methods.

@MathiasReker MathiasReker changed the title PHP unit expectations Simplify PHP unit expectations Dec 9, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

Good job,

thank you @MathiasReker :)

@mickaelandrieu mickaelandrieu merged commit 9974508 into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment