New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong name #11677

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 8, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker MathiasReker changed the title Wrong name Fix wrong name Dec 9, 2018

@mickaelandrieu mickaelandrieu merged commit df55699 into PrestaShop:develop Dec 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

and one more contribution merged 🎉

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 10, 2018

@mickaelandrieu @MathiasReker I am not against this PR but I'm not sure it was wrong in fact 🤔

Namespace root folder spelling is decided by composer.json, not by the filepath if I am not wrong.

https://github.com/PrestaShop/PrestaShop/blob/develop/composer.json#L128 :

"autoload-dev": {
        "psr-4": {
            "LegacyTests\\": "tests-legacy/",
            "Tests\\": "tests/"
        },
        ...
    },

As far as I know you can even put a namespace A\B\C in a folder xx/yy/zz if you configure it properly in composer.json: "A\\B\\C\\": "xx/yy/zz" 😉

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 10, 2018

I put the tests folder in lowercase as it is quite a standard folder name for software projects, but used CamelCase for namespace as it is another standard 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment