New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer: Fix "non printable character" #11685

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 10, 2018

Questions Answers
Branch? develop
Description? Remove Zero-width space (ZWSP), Non-breaking space (NBSP) and other invisible unicode symbols.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker MathiasReker changed the title php-cs-fixer: Add "non printable character" php-cs-fixer: Fix "non printable character" Dec 10, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

ping @eternoendless, this can't fix bugs that are difficult to figure out without it!

WDYT?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 10, 2018

👍

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 10, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 13, 2018

LGTM!

@mickaelandrieu mickaelandrieu merged commit 7c453ea into PrestaShop:develop Dec 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment