New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine consecutive issets #11696

Merged
merged 13 commits into from Dec 14, 2018

Conversation

Projects
None yet
6 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 11, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

Show resolved Hide resolved classes/Context.php Outdated
Show resolved Hide resolved classes/Dispatcher.php Outdated

MathiasReker added some commits Dec 11, 2018

Show resolved Hide resolved classes/Dispatcher.php Outdated
@jolelievre
Copy link
Contributor

jolelievre left a comment

great job again @MathiasReker
but some simplifications remain, can you please lighten the code a bit more? ;)
thank you

Show resolved Hide resolved classes/Cart.php Outdated
Show resolved Hide resolved classes/ObjectModel.php Outdated
Show resolved Hide resolved classes/PrestaShopAutoload.php Outdated
Show resolved Hide resolved classes/checkout/CheckoutDeliveryStep.php Outdated
Show resolved Hide resolved classes/controller/AdminController.php Outdated
Show resolved Hide resolved classes/webservice/WebserviceRequest.php Outdated
Show resolved Hide resolved classes/webservice/WebserviceRequest.php Outdated
Show resolved Hide resolved config/bootstrap.php Outdated
Show resolved Hide resolved config/config.inc.php Outdated
Show resolved Hide resolved controllers/admin/AdminModulesController.php

Quetzacoalt91 and others added some commits Dec 12, 2018

Update classes/ObjectModel.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
@jolelievre
Copy link
Contributor

jolelievre left a comment

@MathiasReker almost good, some extra spaces left
maybe just a php-cs-fixer and we're good to go
Thanks again!

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

@jolelievre fixed :)

@jolelievre
Copy link
Contributor

jolelievre left a comment

thank you @MathiasReker
A second approval from @PrestaShop/prestashop-core-developers and we're good to go

@jolelievre
Copy link
Contributor

jolelievre left a comment

Little syntax error to fix on this one

Show resolved Hide resolved classes/webservice/WebserviceRequest.php Outdated

@PierreRambaud PierreRambaud merged commit 7ca2a5d into PrestaShop:develop Dec 14, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 14, 2018

Thanks everyone :)

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment