New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine consecutive unsets #11697

Merged
merged 29 commits into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 11, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

Show resolved Hide resolved classes/Cookie.php Outdated
@PierreRambaud
Copy link
Contributor

PierreRambaud left a comment

Break lines and it will be ok :)

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 11, 2018

@PierreRambaud Sure, I go afk. But I will fix it tomorrow.

MathiasReker added some commits Dec 12, 2018

MathiasReker added some commits Dec 12, 2018

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

Sorry for commit spam, I used the web editor xD

@Quetzacoalt91 Quetzacoalt91 merged commit 8bd9c9e into PrestaShop:develop Dec 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 12, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 12, 2018

I squashed the commits together. Thank you @MathiasReker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment