New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize types casting #11708

Merged
merged 11 commits into from Dec 13, 2018

Conversation

Projects
None yet
7 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 11, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

@Quetzacoalt91 Thank you for using suggested changes ❤️

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

I don't understand why Travis fail?

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 13, 2018

seems to be the linter which blocks, maybe try to rebase (the already merged PRs) and run php-cs-fixer

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

seems to be the linter which blocks, maybe try to rebase (the already merged PRs) and run php-cs-fixer

hmm.. can you help me fix this? I am stock

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 13, 2018

seems to be the linter which blocks, maybe try to rebase (the already merged PRs) and run php-cs-fixer

hmm.. can you help me fix this? I am stock

Sure I will try this afternoon

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 13, 2018

seems to be the linter which blocks

not only the linter, but also e2e tests: sounds like you have broken something this time @MathiasReker :p

MathiasReker and others added some commits Dec 11, 2018

Update controllers/admin/AdminSearchConfController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update controllers/admin/AdminSearchConfController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update controllers/front/GetFileController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update controllers/front/OrderDetailController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update controllers/front/OrderDetailController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update controllers/front/OrderDetailController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update controllers/front/OrderDetailController.php
Co-Authored-By: MathiasReker <mathias@reker.dk>
Update src/Core/Foundation/Version.php
Co-Authored-By: MathiasReker <mathias@reker.dk>

Quetzacoalt91 and others added some commits Dec 12, 2018

Update src/Core/Foundation/Version.php
Co-Authored-By: MathiasReker <mathias@reker.dk>

@jolelievre jolelievre force-pushed the MathiasReker:p16 branch from 0b2ddce to a4e5c99 Dec 13, 2018

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 13, 2018

seems to be the linter which blocks

not only the linter, but also e2e tests: sounds like you have broken something this time @MathiasReker :p

Yes there was a syntax error in controllers/front/OrderDetailController.php, I fixed it and rebased the PR, waiting for travis right now

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

@jolelievre thanks

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 13, 2018

Ok tests are good, it needs two approvals from @PrestaShop/prestashop-core-developers

@jolelievre jolelievre merged commit c4cc74a into PrestaShop:develop Dec 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 13, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment