Update PHP CS Fixer

[MathiasReker]

Questions	Answers
Branch?	develop
Description?	/
Type?	improvement
Category?	CO
BC breaks?	Does it break backward compatibility? no
Deprecations?	Does it deprecate an existing feature? no
Fixed ticket?	/
How to test?	/

Rule	PR
align_multiline_comment' => ['comment_type' => 'phpdocs_only']	#11694
'array_indentation' => true	#11695
'combine_consecutive_issets' => true	#11696
'combine_consecutive_unsets' => true	#11697
'hash_to_slash_comment' => true	#11699
'logical_operators' => true	#11701
'no_short_echo_tag' => true	#11703
'no_alias_functions' => true	#11707
'modernize_types_casting' => true	#11708
'no_mixed_echo_print' => true	#11709
'no_closing_tag' => true	#11738
'single_blank_line_at_eof' => true	#11738

---

This change is 

[MathiasReker]

WDYT?

[PierreRambaud]

@PrestaShop/prestashop-core-developers Need everyone feedback :)

[Quetzacoalt91]

I won't say no to additional checks, especially if they can be fixed by CS fixer. :)

[jolelievre]

This new setting seems good to me, and thank you for all the other PRs where you cleaned all the code!
I think we should wait to merge all the other PRs before this one.

[Quetzacoalt91]

Of course, this one should not pass the linter jobs until the other PRs are merged. :)

[AJenbo]

Have you guys considered setting up StyleCI? It runs php-cs-fixer as a service.

[Quetzacoalt91]

We are looking for tools, but haven't chosen yet. @eternoendless on its side heard about prettyci.com.

[AJenbo]

Hm I think prettyci.com might actually be a better choice especially if they respect the .php_cs rather then require a separate format.

[MathiasReker]

Please merge this PR.

[Quetzacoalt91]

Hi @MathiasReker,

In order to go on this PR and approve your changes, I restarted the Travis build. Unfortunately it appears the linter jobs are currently failing.
This means more changes must be brought on this PR to make it pass.

[eternoendless]

Looks like some rules are missing:

• no_short_echo_tag
• no_alias_functions
• modernize_types_casting
• no_mixed_echo_print

[MathiasReker]

If some rules are missing now, they are missing because they are already a symfony rule :-)

[PierreRambaud]

Look like you include all @symfony:risky elements, as it says, it is risky :/ but use '@Symfony:risky' => true instead. And do not duplicate rules already in @Symfony, or @Symfony:risky

[MathiasReker]

@PierreRambaud I am not sure I included all risky symfony rules, I picked them one by one. None of included risky rules seems to have any negative affect on on this project. Are you sure would use @Symfony:risky ? What if Cs fixer is updated with new risky rules?

[PierreRambaud]

We have composer.lock which target a specific php-cs-fixer version. It is exactly the same as phpunit, Symfony and all dependencies. We control what we have, and so we should watch diff before updating dependencies.

[MathiasReker]

@PierreRambaud I updated the configuration. Wdyt?

        'native_constant_invocation' => false,
        'native_function_invocation' => false,

[MathiasReker]

WDYT?

I am not sure how to solve Travis CI lint.

[eternoendless]

New commits add more checks than were initially proposed. Can we roll them back and go with the initial suggestion? We can discuss adding others in another PR.

[MathiasReker]

@eternoendless I will do so. I am busy ATM. I will do it ASAP.

[MathiasReker]

I messed something up, trying to squash my commits. New PR: #12922