New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly tests build on Google Cloud Platform #11725
Conversation
…pt nor PHP installed in the target server.
tests/E2E/combine-reports.py
Outdated
from datetime import datetime, timedelta | ||
|
||
|
||
def gt(dt_str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the naming of and in this function are not really good, would you mind improving them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently rewriting it, it's just a POC doing in the train 🙄
@@ -0,0 +1,192 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I remember, @eternoendless wasn't okay with this language. This should be discussed to go on this topic.
For the "should we use Python" debate: if it replaces bash I think it's for the best 👍 |
No need of QA review on this one. Merging. |
This change is