New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly tests build on Google Cloud Platform #11725

Merged
merged 17 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 11, 2018

Questions Answers
Branch? develop
Description? Run tests under gcloud context.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? Wait for travis cron & report files must be store in gcloud bucket.

This change is Reviewable

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:test-travis branch from dcb5658 to dd18755 Dec 12, 2018

@mickaelandrieu mickaelandrieu changed the title [WIP] Nighlies tests [WIP] Nightly tests build on Google Cloud Platform Dec 13, 2018

from datetime import datetime, timedelta


def gt(dt_str):

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Dec 13, 2018

Contributor

the naming of and in this function are not really good, would you mind improving them?

This comment has been minimized.

@PierreRambaud

PierreRambaud Dec 13, 2018

Author Contributor

I'm currently rewriting it, it's just a POC doing in the train 🙄

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:test-travis branch 5 times, most recently from b5734e6 to ea92e11 Dec 14, 2018

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:test-travis branch from ea92e11 to 9103a47 Dec 14, 2018

@PierreRambaud PierreRambaud changed the title [WIP] Nightly tests build on Google Cloud Platform Nightly tests build on Google Cloud Platform Dec 14, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 14, 2018

PierreRambaud added some commits Dec 14, 2018

@@ -0,0 +1,192 @@
#!/usr/bin/env python

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jan 8, 2019

Member

As far as I remember, @eternoendless wasn't okay with this language. This should be discussed to go on this topic.

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 9, 2019

For the "should we use Python" debate: if it replaces bash I think it's for the best 👍

@Quetzacoalt91 Quetzacoalt91 merged commit 846d877 into PrestaShop:develop Jan 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 15, 2019

No need of QA review on this one. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment