Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upNightly tests build on Google Cloud Platform #11725
Conversation
prestonBot
added
develop
Improvement
labels
Dec 11, 2018
Quetzacoalt91
reviewed
Dec 11, 2018
tests/E2E/run-nightly-tests.sh Outdated
PierreRambaud
added some commits
Dec 5, 2018
PierreRambaud
force-pushed the
PierreRambaud:test-travis
branch
from
dcb5658
to
dd18755
Dec 12, 2018
PierreRambaud
added some commits
Dec 12, 2018
mickaelandrieu
changed the title
[WIP] Nighlies tests
[WIP] Nightly tests build on Google Cloud Platform
Dec 13, 2018
mickaelandrieu
reviewed
Dec 13, 2018
tests/E2E/combine-reports.py
Outdated
| from datetime import datetime, timedelta | ||
|
|
||
|
|
||
| def gt(dt_str): |
This comment has been minimized.
This comment has been minimized.
mickaelandrieu
Dec 13, 2018
Contributor
the naming of and in this function are not really good, would you mind improving them?
This comment has been minimized.
This comment has been minimized.
PierreRambaud
Dec 13, 2018
Author
Contributor
I'm currently rewriting it, it's just a POC doing in the train
PierreRambaud
added some commits
Dec 13, 2018
PierreRambaud
force-pushed the
PierreRambaud:test-travis
branch
5 times, most recently
from
b5734e6
to
ea92e11
Dec 14, 2018
PierreRambaud
force-pushed the
PierreRambaud:test-travis
branch
from
ea92e11
to
9103a47
Dec 14, 2018
PierreRambaud
changed the title
[WIP] Nightly tests build on Google Cloud Platform
Nightly tests build on Google Cloud Platform
Dec 14, 2018
PierreRambaud
added this to the 1.7.6.0 milestone
Dec 14, 2018
PierreRambaud
added some commits
Dec 14, 2018
Quetzacoalt91
reviewed
Jan 8, 2019
| @@ -0,0 +1,192 @@ | |||
| #!/usr/bin/env python | |||
This comment has been minimized.
This comment has been minimized.
Quetzacoalt91
Jan 8, 2019
Member
As far as I remember, @eternoendless wasn't okay with this language. This should be discussed to go on this topic.
This comment has been minimized.
This comment has been minimized.
|
For the "should we use Python" debate: if it replaces bash I think it's for the best |
Quetzacoalt91
approved these changes
Jan 15, 2019
Quetzacoalt91
merged commit 846d877
into
PrestaShop:develop
Jan 15, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
No need of QA review on this one. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
PierreRambaud commentedDec 11, 2018
•
edited by eternoendless
This change is