New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write binary #11729

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
5 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 12, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

Wdyt?

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 13, 2018

I don't know at all: what does it change?

/c @matks

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

@mickaelandrieu Windows offers a text-mode translation flag ('t') which will transparently translate \n to \r\n when working with the file. In contrast, you can also use 'b' to force binary mode, which will not translate your data. To use these flags, specify either 'b' or 't' as the last character of the mode parameter.

Doc: http://php.net/manual/kr/function.fopen.php

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 13, 2018

ping @Quetzacoalt91 wdyt?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 14, 2018

Yep I read people advising to use the binary mode.

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 18, 2018

Should be ready to get merged :)

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 18, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 0ed7e95 into PrestaShop:develop Dec 18, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 18, 2018

Thank you @MathiasReker

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment