New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PHP closing tag and no EOL #11738

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 12, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 12, 2018

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 12, 2018

@MathiasReker just a little conflict which appeared and we're good to go

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

@jolelievre fixed.

@jolelievre jolelievre merged commit 0cef290 into PrestaShop:develop Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 12, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment