New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PhpDoc Validate::isColor() #11744

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@EdouardTack
Copy link
Contributor

EdouardTack commented Dec 12, 2018

Questions Answers
Branch? develop
Type? improvement
Category? CO
Description? Fix PhpDoc
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 12, 2018

Hello @EdouardTack!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 12, 2018

Hi!

Your pull request description seems to be incomplete or malformed:

  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

Please change type to improvement

@EdouardTack

This comment has been minimized.

Copy link
Contributor

EdouardTack commented Dec 12, 2018

Ok, i change it

@PierreRambaud PierreRambaud removed the doc label Dec 12, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 12, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 0e1fe6c into PrestaShop:develop Dec 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 12, 2018

Thank you @EdouardTack

@EdouardTack EdouardTack deleted the EdouardTack:patch-1 branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment