New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert comments to php docs in some cases #11747

Merged
merged 6 commits into from Dec 13, 2018

Conversation

Projects
None yet
5 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 12, 2018

Questions Answers
Branch? develop
Description? Convert comments to php docs in some cases
Type? bug fix
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 12, 2018

I would like to work on the docs, so it could be nice to have this merged asap if it is OK :) @PierreRambaud @jolelievre

MathiasReker added some commits Dec 12, 2018

@jolelievre
Copy link
Contributor

jolelievre left a comment

Thanks again @MathiasReker
There are a few missing . at the end of PHPDocs
I think you just need to run php-cs-fixer to fix them
And a comment about src/PrestaShopBundle/Install/Upgrade.php but this one seems to have caused you trouble

Show resolved Hide resolved classes/Page.php
Show resolved Hide resolved classes/Product.php
Show resolved Hide resolved classes/Tools.php
Show resolved Hide resolved classes/module/Module.php
Show resolved Hide resolved classes/module/Module.php
Show resolved Hide resolved classes/order/OrderDetail.php
Show resolved Hide resolved controllers/admin/AdminImportController.php
Show resolved Hide resolved src/Adapter/Module/Tab/ModuleTabRegister.php
Show resolved Hide resolved src/PrestaShopBundle/Install/Upgrade.php
Show resolved Hide resolved src/PrestaShopBundle/Install/Upgrade.php

@jolelievre jolelievre referenced this pull request Dec 13, 2018

Open

Use single quote #11740

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

@jolelievre thanks for your review. Sorry, I did not explain my PR at all. I aim to fix php docs starting with // and /* in this PR. Once this is merged, I have some really nice improvements for the php docs, your comments are already covered by a script I prepared :) But I need this to be merged first please. I is better to split the PR's up in two.

@MathiasReker MathiasReker changed the title Fix php docs Convert comments to php docs in some cases Dec 13, 2018

@jolelievre

This comment has been minimized.

Copy link
Contributor

jolelievre commented Dec 13, 2018

Ok let's not block this one for now then!

@jolelievre
Copy link
Contributor

jolelievre left a comment

@mickaelandrieu mickaelandrieu merged commit c7f5935 into PrestaShop:develop Dec 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 13, 2018

Thanks everyone!

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Dec 13, 2018

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Dec 13, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment