New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong discount details on order page / on invoice #11754

Merged
merged 9 commits into from Jan 2, 2019

Conversation

Projects
None yet
6 participants
@tomlev
Copy link
Member

tomlev commented Dec 12, 2018

Questions Answers
Branch? develop
Description? Fix the details about vouchers on order page and on invoice
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #11541 #11520
How to test? create 2 % vouchers in BO. In FO, checkout a cart with a product and both vouchers. In BO, check order details : discount details should be correct. In BO, set order to status payment received and load invoice : voucher details should be correct

This change is Reviewable

/**
* this class test the correct copy from cart to order
*/
class CartToOrderTest extends CartTaxesTest

This comment has been minimized.

@tomlev

tomlev Dec 12, 2018

Author Member

I know this is not the best way to get fixtures, it's the only one available for now
The fixture process is under heavy development and should be available soon

@mickaelandrieu
Copy link
Contributor

mickaelandrieu left a comment

good for me, but you need to rebase :)

Show resolved Hide resolved classes/Mail.php Outdated

@tomlev tomlev force-pushed the tomlev:issue-11541 branch from 124376c to c91add1 Dec 15, 2018

@eternoendless eternoendless changed the title fix wrong discount details on order page / on invoice Fix wrong discount details on order page / on invoice Dec 18, 2018

@tomlev tomlev force-pushed the tomlev:issue-11541 branch from 1152c85 to 7160595 Dec 21, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 27, 2018

@marionf marionf removed their assignment Dec 27, 2018

Everything has been rebased

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 2, 2019

@PierreRambaud PierreRambaud merged commit 94304d7 into PrestaShop:develop Jan 2, 2019

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 2, 2019

Thanks @tomlev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment