New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix campaign full tests on develop branch #11776

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
5 participants
@YosraAk
Copy link
Contributor

YosraAk commented Dec 14, 2018

Questions Answers
Branch? develop
Description? Adapt the campaign full tests
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 14, 2018

Hello @YosraAk!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@YosraAk YosraAk force-pushed the YosraAk:fix-develop branch 2 times, most recently from 3135449 to 0c518f8 Dec 14, 2018

@mbadrani
Copy link
Contributor

mbadrani left a comment

seems good

@YosraAk YosraAk force-pushed the YosraAk:fix-develop branch from 0c518f8 to b2beb23 Dec 14, 2018

@mbadrani
Copy link
Contributor

mbadrani left a comment

Add this review to approve your PR Yosra

@khouloudbelguith khouloudbelguith added the TE label Dec 14, 2018

@YosraAk YosraAk force-pushed the YosraAk:fix-develop branch from b2beb23 to 722b463 Dec 17, 2018

@YosraAk YosraAk force-pushed the YosraAk:fix-develop branch from 722b463 to 1f73204 Dec 17, 2018

@mbadrani
Copy link
Contributor

mbadrani left a comment

Need to be merged

@mbadrani mbadrani merged commit 2512985 into PrestaShop:develop Dec 18, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.6.0 milestone Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment