New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not perform updateProductRequest() AJAX call if no valid data input #11777

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
5 participants
@matks
Copy link
Contributor

matks commented Dec 14, 2018

Questions Answers
Branch? 1.7.5.x
Description? Do not perform updateProductRequest() AJAX call if no valid data input
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11771
How to test? See ticket #1171 the bug should be fixed. Also the add-to-cart behavior on FO should be unchanged.

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 changed the base branch from develop to 1.7.5.x Dec 14, 2018

@matks matks force-pushed the matks:fix-11771-bad-js-checkout branch 2 times, most recently from bde7eef to b95dd66 Dec 14, 2018

@matks matks force-pushed the matks:fix-11771-bad-js-checkout branch from b95dd66 to 2ce6923 Dec 14, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Dec 14, 2018

@marionf marionf self-assigned this Dec 14, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 14, 2018

@PierreRambaud PierreRambaud merged commit 8bed283 into PrestaShop:1.7.5.x Dec 14, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 14, 2018

Thanks @matks

@matks matks deleted the matks:fix-11771-bad-js-checkout branch Dec 14, 2018

@eternoendless eternoendless changed the title Fix 11771 bad js checkout Do not perform updateProductRequest() AJAX call if no valid data input Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment