New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error is displayed "getimagesize(): php_network_getaddresses" when we try to change the status of the order to payment accepted #11851

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 19, 2018

Questions Answers
Branch? develop
Description? Use absolute path for getimagesize and return the url for pdf generation.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11801
How to test? Follow ticket instruction.

This change is Reviewable

Get logo must only returns logo
- Check path for getimagesize instead of url to prevent docker error
- Use url instead of absolute /relative path for pdf

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 19, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Dec 20, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 36d66b4 into PrestaShop:develop Dec 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/11801 branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment