New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customer_message table name into SQL request #11854

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
5 participants
@Klemart3D
Copy link
Contributor

Klemart3D commented Dec 19, 2018

Questions Answers
Branch? develop
Description? Add customer_message table name into SQL request to prevent "Column 'message' in field list is ambiguous"
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11849
How to test? Tab Clients > SAV. If customer messages are displayed it works.

This change is Reviewable

Add customer_message table name into SQL request
To prevent "Column 'message' in field list is ambiguous"
See issue: #11849

@marionf marionf self-assigned this Jan 7, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 7, 2019

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Jan 7, 2019

Be careful before merging because original issue #11849 was reported on 1.6.1.23
I can't reproduce this issue on develop branch and this PR doesn't change anything for me

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 7, 2019

@PierreRambaud PierreRambaud merged commit 098b690 into PrestaShop:develop Jan 7, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 7, 2019

Thanks @Klemart3D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment