New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP unit set up tear down visibility #11865

Merged
merged 1 commit into from Dec 24, 2018

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 19, 2018

Questions Answers
Branch? develop
Description? Changes the visibility of the setUp() and tearDown() functions of PHPUnit to protected, to match the PHPUnit TestCase.
Type? improvement
Category? TE
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? /

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 20, 2018

Ping @matks, shall we modify these signatures?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 22, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 24, 2018

No need of QA review on this one, as Travis will run these tests. Merging directly.

Thank you @MathiasReker

@Quetzacoalt91 Quetzacoalt91 merged commit 268918d into PrestaShop:develop Dec 24, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment