New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO: Fix lang table multi-store data issue #11876

Merged
merged 2 commits into from Dec 21, 2018

Conversation

Projects
None yet
4 participants
@Dan-Orchard
Copy link
Contributor

Dan-Orchard commented Dec 20, 2018

Questions Answers
Branch? develop
Description? With a multi-store set up, adding a product or category to an individual store will put a line for each of the stores into the object_lang table.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9606
How to test? Create a multi-store - Create a category/product in an individual store - only lines with associated stores will be added to object_lang table rather than for all stores.

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Dec 20, 2018

Hello @Dan-Orchard!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Show resolved Hide resolved classes/ObjectModel.php Outdated

@marionf marionf self-assigned this Dec 20, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 20, 2018

@marionf marionf removed their assignment Dec 20, 2018

@marionf marionf added this to the 1.7.6.0 milestone Dec 20, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit d8f3e85 into PrestaShop:develop Dec 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 21, 2018

Thank you @Dan-Orchard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment