New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categories grid id #11895

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Copy link
Member

sarjon commented Dec 21, 2018

Questions Answers
Branch? develop
Description? Makes categories grid id lower case since its used that way in javascript.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Actions that requires JS should work. For example when you click "Select all" it should select all checkboxes or when you change position it should work as expected.

This change is Reviewable

@ntiepresta ntiepresta self-assigned this Dec 21, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Dec 21, 2018

@ntiepresta ntiepresta removed their assignment Dec 21, 2018

@PierreRambaud PierreRambaud merged commit 0151993 into PrestaShop:develop Dec 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 21, 2018

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 21, 2018

Thanks @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment