New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HelperList title_icon property #11899

Merged
merged 1 commit into from Dec 27, 2018

Conversation

Projects
None yet
4 participants
@matks
Copy link
Contributor

matks commented Dec 21, 2018

Questions Answers
Branch? develop
Description? Introduce title_icon property for HelperList
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #11886
How to test? Follow below instructions to check the feature

How to use it ?

This allows to set a title_icon property that can be used to render an icon at the left of the title of a list generated by HelperList

The smarty variable was already here: https://github.com/PrestaShop/PrestaShop/blob/develop/admin-dev/themes/default/template/helpers/list/list_header.tpl#L127
but could not be used by a HelperList.

Now you can control it:

        $helper = new HelperList();
        $helper->shopLinkType = '';
        $helper->simple_header = false;
        ...
        $helper->title_icon = 'icon-cogs';

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Dec 22, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 27, 2018

@PierreRambaud PierreRambaud merged commit f2ff9c4 into PrestaShop:develop Dec 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 27, 2018

Thanks @matks

@matks matks deleted the matks:introduce-icon_title-for-helper-list branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment