New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix searching issue in the Credit Slips page #11922

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
6 participants
@khouloudbelguith
Copy link
Contributor

khouloudbelguith commented Dec 24, 2018

Questions Answers
Branch? develop
Description? In the BO => Orders => Credit Slips page, when we try to filter with a wrong id order (for example "test") => an exception is displayed
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11921
How to test? Go to BO => Orders => Credit Slips => You need to have more than 2 credit slips => Try to filter with a wrong order id

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 27, 2018

Hello,

can you still filter with order id after this update?

Mickaël

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor Author

khouloudbelguith commented Dec 28, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 2, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 2, 2019

@PierreRambaud PierreRambaud merged commit 588a371 into PrestaShop:develop Jan 2, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 2, 2019

Thanks @khouloudbelguith ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment