New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in SERP component when using non-alphanumeric characters #11923

Merged
merged 2 commits into from Dec 27, 2018

Conversation

Projects
None yet
7 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Dec 24, 2018

Questions Answers
Branch? 1.7.5.x
Description? Improve text getter for SERP component
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #11911
How to test? Add non-alphanumeric characters to the meta description of a product (tab SEO). The preview on search engine must be updated accordingly.

This change is Reviewable

@jolelievre
Copy link
Contributor

jolelievre left a comment

some built files seem to be minified (imports.bundle.js for example), and some other not (contacts.bundle.js among others)
is it the expected output?

@PierreRambaud PierreRambaud modified the milestones: 1.7.6.0, 1.7.5.1 Dec 27, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 27, 2018

@mickaelandrieu mickaelandrieu merged commit dd637a6 into PrestaShop:1.7.5.x Dec 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 27, 2018

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment