New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't sort tax included for now #11932

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
5 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 26, 2018

Questions Answers
Branch? develop
Description? We can't sort the final_price because it is calculated after the sql sort: https://github.com/PrestaShop/PrestaShop/blob/develop/src/Adapter/Product/AdminProductDataProvider.php#L370 we need to define if we need to allow to sort this field and which way we will do that.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11925
How to test? Follow ticket instruction.

This change is Reviewable

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 2, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 2, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 8141284 into PrestaShop:develop Jan 2, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 2, 2019

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/sorting-tax-incl branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment