New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description has a max length and can not exceeded #11936

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
4 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 27, 2018

Questions Answers
Branch? develop
Description? We add a max length for description due to MySQL text field limitation. We need to be consistent and display an error if max length exceeded. Reported by rl_lucian: https://www.prestashop.com/forums/topic/622846-unable-to-update-settings/#comment-2662574
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/description-max-length branch from accb740 to c9f2aeb Dec 27, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 2, 2019

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 2, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit eb144f7 into PrestaShop:develop Jan 2, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 2, 2019

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/description-max-length branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment