New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if intl is installed in installer #11937

Merged
merged 1 commit into from Dec 31, 2018

Conversation

Projects
None yet
8 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Dec 27, 2018

Questions Answers
Branch? 1.7.5.x
Description? Check if intl extension is loaded before running installer
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
How to test? Try to install with and without intl extension.

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Dec 28, 2018

I thought it wasn't a mandatory extension, as I never installed on my environment. Did something change recently?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Dec 28, 2018

It's a mandatory extension for composer.json, Symfony and also to send Mail.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Dec 28, 2018

Ping @eternoendless Should we merge this in 1.7.5.1 (There are issues about missing intl) or develop ?

@PierreRambaud PierreRambaud requested a review from eternoendless Dec 28, 2018

Waiting for the boss

@matks

matks approved these changes Dec 31, 2018

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Dec 31, 2018

Target 1.7.5 is validated by @eternoendless, we can merge!

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Dec 31, 2018

For the record, it has always been required... but visibly it wasn't being enforced.

Thank you @PierreRambaud

@eternoendless eternoendless merged commit 70c8711 into PrestaShop:1.7.5.x Dec 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:install-check-intl branch Dec 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment