New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make customer's product customization information reachable in WebServices #11938

Merged
merged 3 commits into from Dec 28, 2018

Conversation

Projects
None yet
5 participants
@eternoendless
Copy link
Member

eternoendless commented Dec 27, 2018

Questions Answers
Branch? develop
Description? PrestaShop allows customer-customizable products, like the customizable mug. But once an order is placed, there's no way of retrieving what the customer wrote, using the Web Services. We have a customization object, but there's no way to find out what order it belongs to. With this change, when you look up an order or a cart, you'll get the id_customization in the "rows" section, where you'll get an xlink to the detailed information.
Type? improvement
Category? WS
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? First case: Place an order including a customizable product. Using your web service key, go to /api/carts to find out the URL for your latest cart. Open it, scroll down to the cart_rows section, find the id_customization element. Go to the customization URL, see that the text is the same as you wrote.
Second case: Repeat the first case but with /api/orders.
Third case: Check out what happens if you order/include products without customizations.

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.6.0 milestone Dec 27, 2018

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Dec 28, 2018

@eternoendless

When the order include products without customization, I have this:

capture d ecran_830

I don't know if it's the wanted behavior or if the id_customization element shouldn't be displayed in this case ?

@marionf marionf added QA ✔️ and removed waiting for QA labels Dec 28, 2018

@PierreRambaud PierreRambaud merged commit ba8b977 into PrestaShop:develop Dec 28, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Dec 28, 2018

@eternoendless

This comment has been minimized.

Copy link
Member Author

eternoendless commented Dec 28, 2018

@marionf I noticed the same thing, but I don't know if it's a bug in the system (it's handled the same way everywhere), or if it's per design. Since we're in uncharted territory, I guess it's not a big deal, at least for this PR.

@eternoendless eternoendless deleted the eternoendless:add-ws-customization branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment