New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is null #11992

Merged
merged 1 commit into from Jan 17, 2019

Conversation

Projects
None yet
4 participants
@MathiasReker
Copy link
Contributor

MathiasReker commented Dec 31, 2018

Questions Answers
Branch? develop
Description? /
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? /
How to test? Nothing to test

This change is Reviewable

@@ -693,7 +693,7 @@ protected function updateWebservice($use_webservice)
);
$context_options = array('http' => array(
'method' => (is_null($webservice_id) == true) ? 'POST' : 'PUT',
'method' => ((null === $webservice_id) == true) ? 'POST' : 'PUT',

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jan 7, 2019

Member

No need to modify these files as they are not run. And otherwise, the test could have been simplified. :)

This comment has been minimized.

@MathiasReker

MathiasReker Jan 7, 2019

Author Contributor

I understand that the tests are not run, but can we merge all the changes or do you want me to revert some of the changes? :)

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jan 17, 2019

Contributor

I think it's ok for now: it was stupid before, it's still stupid after and this introduces no regression :D

@MathiasReker MathiasReker force-pushed the MathiasReker:is-null branch from 09e6b68 to 4cc384f Jan 7, 2019

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Jan 17, 2019

@mickaelandrieu mickaelandrieu merged commit a9d15d0 into PrestaShop:develop Jan 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Jan 17, 2019

Thanks @MathiasReker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment