New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters in catalog page #12001

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
5 participants
@ansar21mallouli
Copy link
Contributor

ansar21mallouli commented Jan 2, 2019

Questions Answers
Branch? develop
Description? This script tests the sort and filters in the catalog page
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? TEST_PATH=full/02_product/08_filters_in_catalog_page.js npm run specific-test -- --URL=URLFrontOffice

This change is Reviewable

@ansar21mallouli ansar21mallouli force-pushed the ansar21mallouli:filters_and_search_in_catalog_page branch from c252d7f to 5627357 Jan 2, 2019

@mbadrani
Copy link
Contributor

mbadrani left a comment

except some blocking points on codacy

@ansar21mallouli

This comment has been minimized.

Copy link
Contributor Author

ansar21mallouli commented Jan 2, 2019

Travis is failed due to unit tests (timezone)
Thanks

@PierreRambaud PierreRambaud added the TE label Jan 2, 2019

@ansar21mallouli ansar21mallouli force-pushed the ansar21mallouli:filters_and_search_in_catalog_page branch from 5627357 to 2fd908b Jan 3, 2019

@ansar21mallouli ansar21mallouli force-pushed the ansar21mallouli:filters_and_search_in_catalog_page branch from 2fd908b to cb2eb15 Jan 3, 2019

@mbadrani
Copy link
Contributor

mbadrani left a comment

All good thanks!

@eternoendless eternoendless added this to the 1.7.6.0 milestone Jan 4, 2019

@mbadrani mbadrani merged commit 846a75a into PrestaShop:develop Jan 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment