New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate legacy tests into suites to fix develop branch #12013

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@matks
Copy link
Contributor

matks commented Jan 3, 2019

Questions Answers
Branch? develop
Description? Some legacy tests fail if the tests are executed as a whole. Probably a caching feature that overlaps and makes test A modifies test B output. This PR isolates the failing tests into a dedicated test suite to fix it.
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Travis should be green

This change is Reviewable

@Quetzacoalt91
Copy link
Member

Quetzacoalt91 left a comment

It's something

@Quetzacoalt91 Quetzacoalt91 merged commit c40fb0c into PrestaShop:develop Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xibe

This comment has been minimized.

Copy link

xibe commented Jan 3, 2019

50,000th commit! Congrats! :)
image

@matks matks deleted the matks:fix-unit-tests-develop-2 branch Jan 3, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 3, 2019

Thanks @xibe 😄

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment