Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify algorithm for calculating average tax rate for products in a cart #12014
Conversation
eternoendless
added this to the 1.7.6.0 milestone
Jan 3, 2019
prestonBot
added
develop
Bug
labels
Jan 3, 2019
Quetzacoalt91
reviewed
Jan 7, 2019
Quetzacoalt91
added
the
waiting for QA
label
Jan 7, 2019
marionf
self-assigned this
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
Product price tax excl: 10€ Before this PR, it's ok: With this PR, it's not ok: |
marionf
added
waiting for author
and removed
waiting for QA
labels
Jan 8, 2019
eternoendless
dismissed
Quetzacoalt91’s
stale review
via
4bbf689
Jan 8, 2019
eternoendless
removed
the
waiting for author
label
Jan 8, 2019
Quetzacoalt91
approved these changes
Jan 8, 2019
Quetzacoalt91
added
the
waiting for QA
label
Jan 8, 2019
This comment has been minimized.
This comment has been minimized.
marionf
added
QA ✔️
and removed
waiting for QA
labels
Jan 8, 2019
marionf
removed their assignment
Jan 8, 2019
Quetzacoalt91
merged commit a22ac95
into
PrestaShop:develop
Jan 9, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
Thank you @eternoendless |
eternoendless
deleted the
eternoendless:avg-tax-rate
branch
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
eternoendless commentedJan 3, 2019
•
edited
Cart::getTaxesAverageUsed()
and$cart->getAverageProductsTaxRate()
. They used a different algorithm to calculate it, but it more or less ended up in "sum of all products without tax / sum of all taxes applied". This PR unifies the behavior and depreciates the static method.This change is